Open RouteController to custom location snapping #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boldtrn
reviewed
Jul 17, 2024
| @@ -230,7 +230,13 @@ open class RouteController: NSObject, Router { | |||
| - important: If the rawLocation is outside of the route snapping tolerances, this value is nil. | |||
| */ | |||
| var snappedLocation: CLLocation? { | |||
| self.rawLocation?.snapped(to: self.routeProgress.currentLegProgress) | |||
| let snappedDefault = self.rawLocation?.snapped(to: self.routeProgress.currentLegProgress) | |||
There was a problem hiding this comment.
Aren't you doing duplicated work here? If there is a delegate, the delegate should do the snapping, otherwise the default snapping happens.
boldtrn
requested changes
Jul 17, 2024
sotomski
changed the title
boldtrn
approved these changes
Jul 18, 2024
|
Sure thing 👍 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR opens the
RouteController.snappedLocationto be additionally modified by delegate implementers.This is useful to plug in a custom snapping logic.
Infos for Reviewer
The intention was to open up the snapping logic but make it optional and don't change snapping behavior if custom logic is not provided. If custom snapping doesn't provide a valid value (ie. fails), the default snapping shall be used as fallback.